Skip to content

[release-4.19] OCPBUGS-60517: fix(azure): resolve credential caching issues around UAMI support #1243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 14, 2025
Merged

[release-4.19] OCPBUGS-60517: fix(azure): resolve credential caching issues around UAMI support #1243

merged 3 commits into from
Aug 14, 2025

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #1238

/assign openshift-ci-robot

@bryan-cox
fix(azure): fix credential caching key mismatch in driver storageAcco…
2b5d887 
…untsClient

Similar to the azureclient fix, use consistent azureCredentialsKey for both
storing and loading cached credentials instead of mixing azureCredentialsKey
and userAssignedIdentityCredentialsFilePath. This prevents repeated credential
recreation in the Azure driver's storageAccountsClient method.
@bryan-cox
fix(azure): fix credential caching key mismatch in azureclient
5e3c399 
Use consistent azureCredentialsKey for both storing and loading cached
credentials instead of mixing azureCredentialsKey and
userAssignedIdentityCredentialsFilePath. This prevents repeated credential
recreation in the Azure driver's storageAccountsClient method.

Signed-off-by: Bryan Cox <[email protected]>
@bryan-cox
feat(azure): add ensureUAMICredentials function with comprehensive tests
3cc346b 
- Add ensureUAMICredentials function to obtain and cache Azure TokenCredential using User Assigned Managed Identity (UAMI)
- Function loads credentials from global cache or creates new ones with proper environment configuration
- Add comprehensive unit tests covering environment variable handling, cache behavior, and error scenarios
- Tests use table-driven pattern following codebase conventions and t.Setenv for proper environment handling
- Update Azure client instantiation to use UAMI credentials when available
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 14, 2025
Merged
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Detected clone of Jira Issue OCPBUGS-59734 with correct target version. Will retitle the PR to link to the clone.
/retitle [release-4.19] OCPBUGS-60517: fix(azure): resolve credential caching issues around UAMI support

In response to this:

This is an automated cherry-pick of #1238

/assign openshift-ci-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.19] OCPBUGS-59734: fix(azure): resolve credential caching issues around UAMI support [release-4.19] OCPBUGS-60517: fix(azure): resolve credential caching issues around UAMI support Aug 14, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 14, 2025
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-60517, which is invalid:

  • expected dependent Jira Issue OCPBUGS-59734 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #1238

/assign openshift-ci-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sjenning sjenning added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Aug 14, 2025
@sjenning
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2025
@bryan-cox
Copy link
Member

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 14, 2025
@openshift-ci-robot
Copy link
Contributor

@bryan-cox: This pull request references Jira Issue OCPBUGS-60517, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.z) matches configured target version for branch (4.19.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-59734 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-59734 targets the "4.20.0" version, which is one of the valid target versions: 4.20.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@xiuwang
Copy link

xiuwang commented Aug 14, 2025

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Aug 14, 2025
@sjenning sjenning added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: openshift-cherrypick-robot, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 328419e and 2 for PR HEAD 3cc346b in total

@bryan-cox
Copy link
Member

/test e2e-aws-operator

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 14, 2025

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-operator 3cc346b link false /test e2e-azure-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 3335b12 into openshift:release-4.19 Aug 14, 2025
15 of 16 checks passed
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-60517: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-60517 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #1238

/assign openshift-ci-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-image-registry-operator
This PR has been included in build ose-cluster-image-registry-operator-container-v4.19.0-202508142008.p0.g3335b12.assembly.stream.el9.
All builds following this will include this PR.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.19.0-0.nightly-2025-08-15-012059

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flavianmissi flavianmissi Awaiting requested review from flavianmissi

@ricardomaraschini ricardomaraschini Awaiting requested review from ricardomaraschini

Assignees

@sjenning sjenning

@xiuwang xiuwang

@wewang58 wewang58

@openshift-ci-robot openshift-ci-robot

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@openshift-cherrypick-robot @openshift-ci-robot @sjenning @bryan-cox @xiuwang @openshift-bot @openshift-merge-robot @wewang58